[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551878





--- Comment #12 from Michael Schwendt <mschwendt at gmail.com>  2010-01-08 18:33:21 EDT ---
 > install -m 644 !(static).py?(c|o) $(DESTDIR)$(prefix)/share/font-manager/

install -m 644 *.py{,c,o} $(DESTDIR)$(prefix)/share/font-manager/
rm $(DESTDIR)$(prefix)/share/font-manager/static.py*

:-)


> but in the Makefile, I have :
> 
> @python -OO -m compileall .
> 
> So, it seems to compile with -O2 if I understand correctly. Am I wrong here?

$ grep compile src/Makefile.am
        @python -m compileall .
        @python -OO -m compileall .

That creates .pyc files in first pass and .pyo files in second pass. Then with
regard to

$ python --help|grep OO
-OO    : remove doc-strings in addition to the -O optimizations

and
https://fedoraproject.org/wiki/Packaging:Python#Including_pyos
https://fedoraproject.org/wiki/Packaging:Python#Byte_Compiled_Files

I thought you could compile with plain -O as rpmbuild's
/usr/lib/rpm/brp-python-bytecompile script does it. Not a blocker, though. It's
not a MUST in the guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.