[Bug 553908] Review Request: rubygem-shoulda - Making tests easy on the fingers and eyes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553908

Ruben Kerkhof <ruben at rubenkerkhof.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ruben at rubenkerkhof.com
         AssignedTo|nobody at fedoraproject.org    |ruben at rubenkerkhof.com
               Flag|                            |fedora-review?

--- Comment #1 from Ruben Kerkhof <ruben at rubenkerkhof.com> 2010-01-09 11:12:28 EST ---
Hi Jeroen,

- You're missing a BuildRequires on dos2unix
- You're missing a BuildRequires on rubygem-rake, rubygem-sqlite3-ruby,
rubygem-mocha and rubygem-rails (for the tests)

Other than that, the tests fail for me as well, with the following output:

  1) Error:
test: Post should require body to be set. (PostTest):
ArgumentError: interning empty string
   
config/initializers/./../../../lib/shoulda/active_record/matchers/allow_value_matcher.rb:62:in
`errors_match?'
   
config/initializers/./../../../lib/shoulda/active_record/matchers/allow_value_matcher.rb:43:in
`matches?'
   
config/initializers/./../../../lib/shoulda/active_record/matchers/validation_matcher.rb:44:in
`disallows_value_of'
   
config/initializers/./../../../lib/shoulda/active_record/matchers/validate_presence_of_matcher.rb:32:in
`matches?'
    config/initializers/./../../../lib/shoulda/assertions.rb:49:in
`assert_accepts'
    config/initializers/./../../../lib/shoulda/active_record/macros.rb:41:in
`__bind_1263053408_210423'
    config/initializers/./../../../lib/shoulda/context.rb:351:in `call'
    config/initializers/./../../../lib/shoulda/context.rb:351:in `test: Post
should require body to be set. '

  2) Failure:
test: should fail when trying to run: should require unique value for title.
(PostTest)
    [/test/fail_macros.rb:33:in `__bind_1263053408_330430'
     config/initializers/./../../../lib/shoulda/context.rb:351:in `call'
     config/initializers/./../../../lib/shoulda/context.rb:351:in `test: should
fail when trying to run: should require unique value for title. ']:
<Test::Unit::AssertionFailedError> exception expected but was
Class: <ArgumentError>
Message: <"interning empty string">
---Backtrace---
config/initializers/./../../../lib/shoulda/active_record/helpers.rb:5:in `map'
config/initializers/./../../../lib/shoulda/active_record/helpers.rb:5:in
`pretty_error_messages'
config/initializers/./../../../lib/shoulda/active_record/matchers/allow_value_matcher.rb:95:in
`error_description'
config/initializers/./../../../lib/shoulda/active_record/matchers/allow_value_matcher.rb:51:in
`negative_failure_message'
config/initializers/./../../../lib/shoulda/active_record/matchers/validation_matcher.rb:45:in
`disallows_value_of'
config/initializers/./../../../lib/shoulda/active_record/matchers/validate_uniqueness_of_matcher.rb:103:in
`validate_attribute'
config/initializers/./../../../lib/shoulda/active_record/matchers/validate_uniqueness_of_matcher.rb:72:in
`matches?'
config/initializers/./../../../lib/shoulda/assertions.rb:49:in `assert_accepts'
config/initializers/./../../../lib/shoulda/active_record/macros.rb:74:in
`__bind_1263053408_330430'
/usr/lib/ruby/1.8/erb.rb:716:in `to_proc'
/test/fail_macros.rb:33:in `__bind_1263053408_330430'
config/initializers/./../../../lib/shoulda/context.rb:351:in `call'
config/initializers/./../../../lib/shoulda/context.rb:351:in `test: should fail
when trying to run: should require unique value for title. '
---------------

463 tests, 578 assertions, 1 failures, 1 errors

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.