[Bug 462253] Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462253


Chris Weyl <cweyl at alumni.drew.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu
              Alias|                            |perl-Cache-FastMmap




--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu>  2008-09-15 00:47:16 EDT ---
A couple comments -- and, looks good, especially for a first package :)

There are tests that are skipped due to the non-presence of certain modules. 
perl(GTop) and perl(Compress::Zlib) should be added as buildrequires to enable
those tests to be run on the buildsystem.  (In general, all additional modules
required to enable optional tests should be buildrequire'ed; the exception is
for "author" or "subjective" tests, like Test::Pod::Coverage,
Test::Perl::Critic, or Test::Kwalitee.)

Aside from that, a scratch build looked good: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=825581

%description isn't the best, but then, it's what the module author used.

Update to include the missing br's listed above, and I'll take a closer look at
this one.  Do you have any other packages up for review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.