Minor tweaks to perl-Sort-Versions in EL-4 branch

Stepan Kasal skasal at redhat.com
Mon Mar 16 14:23:23 UTC 2009


Hello Paul,

> this morning I built the newly-created EL-4 version of  
> perl-Sort-Versions. I made a few very minor tweaks from the EL-5  
> version, which is essentially the same as the devel branch:

thanks for your mail.  I expanded on the points you touched:

>  * Get rid of rpmlint complaint about mixed spaces and tabs

Yes, and I noticed the BuildRoot line is suboptimal: I like the
mktemp version more.

>  * Change encoding of Changes and Versions.pm (and its manpage)
>    from ISO-8859-1 to UTF-8

That's usually done by an iconv command in %prep; it's more clear
expression of the intent.

>  * Make "-depth" the first option in the find command it's used in

Correct.
While I was there, I deployed -empty and combined the two find commands
to one.  (Another option would be to use "|xargs rm -f" for the files
and then remove the empty dirs.)

> I think it would make sense to merge these or equivalent changes into  
> the other branches whenever the next update happens.

Agreed, thanks again.  For now, it's in devel, and it might be used
in other branches if they need to be touched.

Stepan




More information about the Fedora-perl-devel-list mailing list