rpms/perl-Sort-Versions/devel perl-Sort-Versions.spec,1.9,1.10

Stepan Kasal skasal at redhat.com
Thu Mar 19 14:01:10 UTC 2009


Hi Ralf,

On Thu, Mar 19, 2009 at 02:32:59PM +0100, Ralf Corsépius wrote:
>>  for f in Changes Versions.pm; do
>> -	iconv -f iso-8859-1 -t utf-8 <$f >${f}_ && mv ${f}_ $f
>> +	iconv -f iso-8859-1 -t utf-8 <$f >${f}_ &&
>> +	touch -r $f ${f}_ &&
>> +	mv ${f}_ $f
>>  done
>
>>  %changelog
>> +* Thu Mar 19 2009 Stepan Kasal <skasal at redhat.com> - 1.5-11
>> +- fix timestamps of the recoded text files
>
> Why this change? Adjusting timestamps on perl modules is painting bikesheds.

OTOH, touching changelog during rpm build is not a good idea, so the
recode command should preserve the timestamp.

By fixing my recent commit, I made a note to self to do the
	iconv && touch && mv
right next type I'll use it somewhere.

(Hopefully, this thread will alse help me to remember better.)

I agree the importance of this change is close to 0, yet I think it
was not a mistake to cmmit it.

Stepan




More information about the Fedora-perl-devel-list mailing list