[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: kernel for testing



On Sun, Aug 15, 2004 at 06:59:43AM -0500, Mike Chambers wrote:
> 
> Yep, got the same thing here.  So far the below kernels give me the
> problems above with nfs...
> 
> kernel-2.6.7-1.515
> kernel-2.6.7-1.517
> kernel-2.6.8-1.520

It looks like that the following patch

===== fs/nfs/file.c 1.40 vs edited =====
--- 1.40/fs/nfs/file.c	2004-08-09 14:58:00 -04:00
+++ edited/fs/nfs/file.c	2004-08-13 22:54:01 -04:00
@@ -72,7 +72,7 @@
 
 static int nfs_check_flags(int flags)
 {
-	if (flags & (O_APPEND | O_DIRECT))
+	if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))
 		return -EINVAL;
 
 	return 0;
@@ -89,7 +89,7 @@
 	int res;
 
 	res = nfs_check_flags(filp->f_flags);
-	if (!res)
+	if (res)
 		return res;
 
 	lock_kernel();

was not included.  At least for kernel-2.6.8-1.520.

The above was posted by Jeff Garzik on lkml and that piece missing
was the reason for a "paper bag" 2.6.8.1 release.  Look for
a posting "[PATCH] Re: [2.6.8-rc4-bk] NFS oops on x86-64" from
13 Aug 2004 23:23:34 -0400 and a Linus comment "Ahh. Jeff posted the
right one, obviously".

Is a bugzilla ticket opened for this bug?  Curiously enough
I was not hit by that even when using NFS.

   Michal



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]