[Bug 254229] gcore produces incorrect elf_prpsinfo note data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gcore produces incorrect elf_prpsinfo note data


https://bugzilla.redhat.com/show_bug.cgi?id=254229





------- Additional Comments From jan.kratochvil at redhat.com  2008-07-29 08:14 EST -------
(In reply to comment #14)
> Fixed one 80 column rule violation, don't know what to do with this one:

http://www.gnu.org/prep/standards/standards.html
does not talk about 80 columns at all.

I hope it is just really a detail how to format it.
`indent -gnu' will do:
char *(*linux_elfcore_write_prpsinfo)
  (bfd *, char *, int *, void *, const char *, const char *) = 
  elfcore_write_prpsinfo;
but it will leave the other forms without reformatting.
I would find better to follow the existing style around in the code there:
char *(*linux_elfcore_write_prpsinfo)
  (bfd *, char *, int *, void *, const char *, const char *)
  = elfcore_write_prpsinfo;
and while writing it as GNU compliant new I would probably choose:
char *(*linux_elfcore_write_prpsinfo) (bfd *, char *, int *, void *, 
                                       const char *, const char *)
  = elfcore_write_prpsinfo;

but I hope it should not matter much (as long as it is <=80) to have better
chance of an upstream acceptance (not that I would be too much successful).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.