[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [fedora-virt] Re: virt-inspector calling guestfs_umount_all() before launch()?



On Thu, May 28, 2009 at 10:53:20PM +0100, Richard W.M. Jones wrote:
> On Thu, May 28, 2009 at 04:19:21PM -0500, Charles Duffy wrote:
> > Just curious -- do you intend to push the patch ("-snapshot" in  
> > virt-inspector) into the tree?
> 
> I guess we can, but is there a better way?

Right, had a think about this over the weekend, found and read the
qemu documentation, and I have added this patch:

http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=bfdc03be234d6d95f18450846433bce4f97e184c

It adds a 'guestfs_add_drive_ro' call, which is equivalent to the qemu
parameter: -drive file=<filename>,snapshot=on

I've also updated virt-inspector so that it mounts all drives using
this flag.

That copes with the simple/common case.  For more complex cases, use
the guestfs_config function.  I'm not intending to map the entire qemu
parameter space into the libguestfs API.  For a start, they keep
changing it, and we're tied to qemu anyhow.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 75 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]