[Fedora-xen] Re: fedora-xen-ia64 integration, step 1

[Juan Quintela]

On Fri, 2006-06-02 at 11:32 -0400, Aron Griffis wrote:
> Hi Dave and Juan,

Hi Aron



> --
> This patch makes the following changes to the kernel specfile:
> 
>     - abstract xenlinux build using xen_flags, xen_target and
>       xen_image instead of assuming x86 behavior
> 
>     - add xen_* overrides to %ifarch ia64, won't be used until
>       buildxen is flipped on for ia64
> 
>     - run the xen-mkbuildtree-pre hook following applying the xen
>       patch.  This touches a couple files on ia64 but doesn't
>       interfere with any patching down the line.  (I and others have
>       been submitting patches to xen-ia64-devel and xen-devel to
>       further reduce its function, but it should be harmless as-is.)

I think that this one is not acceptable :(
We compile from the same source on _all_ architectures.  If the source
changes  from architecture to architecture, we are broken :(

Notice also that I do my compile testing as something like:i 

cd tree
for arch in $CONFIGS; do
	make O=../$ARCH all
done

Or somesuch. What is on that patch, anyways.

>     - update numerous hardcoded references to /boot to usetu
>       %{image_install_path} instead.  But make an exception for the
>       xenU kernels which never need to be available for system
>       boot.

Uh, oh.  If everything happens as I hope, after this weekend, xenU
kernel is history.  xen0 & xenU kernels are going to be the same
kernel :p  You need another solution here.  I haven't studied the ia64
efi thing to be able to suggest anything, sorry.

>     - build the hypervisor with %{?_smp_mflags} (it works fine)

 
>  %if %{buildup}
> -BuildKernel %make_target %kernel_image
> +BuildKernel %{make_target} %{kernel_image}
>  %endif

Any reason why you do this changes?  in space separated cases, it
shouldn't be needed the use of {}

Hope that this helps.

Later, Juan.