[Fedora-xen] virt* source

[Daniel P. Berrange]

On Fri, Jan 11, 2008 at 10:50:36PM +0900, John Summerfield wrote:
> Richard W.M. Jones wrote:
> >John Summerfield wrote:
> >>virtinst--devel/virtinst/ParaVirtGuest.py:        cmd = 
> >>["/usr/bin/virsh", "console", "%s" %(self.domain.ID(),)]
> >>
> >>Surely, the location of executable components should not be hard-coded 
> >>in the source tree. I could live with it, grudgingly, if it was set at 
> >>configure time.
> >
> >Agreed -- this is simply a bug in virt-manager.
> 
> There are a few other places the virt* programs have fixed ideas about 
> where stuff must be:

Most of these are not bugs because they are testsuites, or because 
these paths are being validated because other apps we call already
expect the paths in those locations - so even if virt-install wished
to use non-absolute paths it couldn't.

There are the only two which could potentially be fixed to use a relative
path, and let the os.execvp/execlp call find the binary. Patches welcomed...

> virtinst--devel/virt-install:    args = ["/usr/bin/virt-viewer"]
> virtinst--devel/virt-install:    args = ["/usr/bin/virsh"]


Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|