[Freeipa-devel] [PATCH] basic connection pool and user search

[Kevin McCarthy]

Rob Crittenden wrote:
> diff -r 491d5b50aabb -r 90e45700faff ipa-server/xmlrpc-server/funcs.py
> --- a/ipa-server/xmlrpc-server/funcs.py	Fri Aug 10 08:15:23 2007 -0400
> +++ b/ipa-server/xmlrpc-server/funcs.py	Mon Aug 13 16:41:38 2007 -0400

[snip]

> @@ -210,12 +248,24 @@ class IPAServer:
>          """Return a list containing a User object for each
>          existing user.
>          """
> +        global _LDAPPool
> +    
> +        if opts:
              ^^^
this seems to be using a variable opts that isn't defined in
get_all_users().  did I miss a patch?

> +            self.set_principal(opts['remoteuser'])
> +
> +        try:
> +            dn = self.get_dn_from_principal(self.princ)
> +        except ldap.LDAPError, e:
> +            raise xmlrpclib.Fault(1, e)
> +        except ipaserver.ipaldap.NoSuchEntryError:
> +            raise xmlrpclib.Fault(2, "No such user")
>      
>          # FIXME: Is this the filter we want or should it be more specific?
>          filter = "(objectclass=posixAccount)"
>          try:
> -            m1 = ipaserver.ipaldap.IPAdmin(self.host,self.port,self.bindca,self.bindcert,self.bindkey)
> +            m1 = _LDAPPool.getConn(self.host,self.port,self.bindca,self.bindcert,self.bindkey,dn)
>              all_users = m1.getList(self.basedn, self.scope, filter, None)
> +            _LDAPPool.releaseConn(m1)
>          except ldap.LDAPError, e:
>              raise xmlrpclib.Fault(1, e)
>          except ipaserver.ipaldap.NoSuchEntryError:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070815/ab883997/attachment.bin>