[Freeipa-devel] [PATCH] another attempt at argument handling

Rob Crittenden rcritten at redhat.com
Wed Aug 22 20:19:49 UTC 2007


This patch takes a different tact on argument handling. It fixes things 
up before even sending them across the XML-RPC connection. rpcclient.py 
now makes sure that all arguments are sent and if any are None, replaces 
them with the text __NONE__.

On the XML-RPC server side __NONE__ is translated back into None. 
Functions are called with a fixed set of arguments which has the 
side-effect of providing better feedback when a function call is done wrong.

The net-effect of this is that optional arguments are handled the same 
way for both direct and XML-RPC clients.

This also splits out get_user() into get_user_by_uid() and get_user_by_dn().

Fixed mark_user_as_deleted() so it doesn't try to re-mark a user already 
marked as deleted. Saves an LDAP transaction.

I also made some of the command-line tools slightly more user-friendly.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-118-fixargs.patch
Type: text/x-patch
Size: 19645 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070822/0bf63abc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070822/0bf63abc/attachment-0001.bin>


More information about the Freeipa-devel mailing list