[Freeipa-devel] [PATCH] Group support

[Kevin McCarthy]

Simo Sorce wrote:
> On Mon, 2007-08-27 at 09:11 -0700, Kevin McCarthy wrote:
> > Rob Crittenden wrote:
> > > This quite large patch includes initial support for Groups. It also:
> > >
> > > Create separate object for Users and Groups (using same base class)
> > > Check for uniqueness before adding new users and groups
> > > Remove user_container from everything but add operations
> > > Abstract out a number of functions that are common across users and groups
> > > Make sure all strings passed in to be in a filter are checked
> > > Add new error message: No modifications specified
> > >
> > > It is bound to conflict with other patches floating around. Once those get 
> > > committed I'll see about merging this in and submitting a new one. Just 
> > > wanted to get some eyeballs on this first.
> > 
> > Approved.  I have a few comments below we can discuss but shouldn't hold
> > up the patch committing.
> > 
> > There are going to be a few conflicts with this and previous patches
> > that are still queued.
> > 
> > Team:  Is there a way we can get these patches committed faster?  Rob
> > and I are really starting to step on each others toes all the time, and
> > we are going to spend more time merging conflicts than being productive
> > if we don't find a solution here.
> 
> Kevin, Rob, you know you can import each other patches without waiting
> on them being committed to the main tree?
> (Just use hg import patchfile)
> 
> Don't wait on the main tree, if a patch is obviously good, just grab it
> right away and import it in your tree so that the following work can
> depend on it.

Good point that I didn't think of.  Rob, since we're working in the same
space, we should be more sensitive to grabbing each other's patch files.
I'll grab yours now and start merging some of my next patches using it.

> As a courtesy you can list the uncommitted patches another patch depends
> on when you post a new patch for review, but that's absolutely not
> required.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070827/696ae63a/attachment.bin>