[Freeipa-devel] [PATCH] user provided certs

[Rob Crittenden]

Karl MacMillan wrote:
> Add a utility to import user provided certs in pkcs#12 format.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

You are missing a close after the write in set_http_cert_name()

I'm guessing that python automatically closes it when fd goes out of 
scope but still...

I'm not sure why you don't use installutils.update_file() to replace 
file.append('NSSNickname').

Otherwise it looks ok.


rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071212/8958b102/attachment.bin>