[Freeipa-devel] [PATCH] user provided certs

[Rob Crittenden]

Karl MacMillan wrote:
> On Wed, 2007-12-12 at 11:05 -0500, Rob Crittenden wrote:
>> Karl MacMillan wrote:
>>> Add a utility to import user provided certs in pkcs#12 format.
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>> You are missing a close after the write in set_http_cert_name()
>>
>> I'm guessing that python automatically closes it when fd goes out of 
>> scope but still...
>>
> 
> It does, but I'll fix before pushing.
> 
>> I'm not sure why you don't use installutils.update_file() to replace 
>> file.append('NSSNickname').
>>
> 
> That can't properly handle cert nicknames with spaces.
> 
> Karl
> 

Ok, acked.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071212/83e5de32/attachment.bin>