[Freeipa-devel] Re: [PATCH] build fixes
Kevin McCarthy
kmccarth at redhat.com
Thu Oct 18 15:22:10 UTC 2007
Karl MacMillan wrote:
> On Thu, 2007-10-18 at 10:37 -0400, William Jon McCann wrote:
> > On 10/18/07, William Jon McCann <mccann at jhu.edu> wrote:
> > > On 10/18/07, Karl MacMillan <kmacmill at redhat.com> wrote:
> > > > This patch fixes the dist and local-dist targets from the recent
> > > > autoconf import. It also makes some minor fixes to the spec files.
> > > >
> > > > One remaining question: when I make the source tarballs for distribution
> > > > I'm running autogen.sh. However, that runs configure which, I think, is
> > > > not typically run before distributing the source. Should I just remove
> > > > the configure step from autogen.sh?
> > >
> > > No. At least in my experience the proper way to do a release is to:
> > >
> > > Pull a fresh tree or run make maintainer-clean (does not have
> > > configure or Makefile)
> > > Run autogen.sh (which builds configure, runs configure, creates Makefile)
> > > Run "make distcheck" (which requires Makfile)
> > >
> > > Also, looks like parts of the autotools patches didn't get committed
> > > and needs fixing up:
> > > * autogen.sh should have +x mode
> > > * Running autogen.sh gives:
> > > Makefile.am: required file `./NEWS' not found
> > > Makefile.am: required file `./README' not found
> > > Makefile.am: required file `./AUTHORS' not found
> >
> > Seems like "hg diff" doesn't report locally added files by default.
> > But hg diff --git does. Weird. What should I be using?
> >
>
> Oh, and hg export preserves checkin comments and, I think, mode changes
> where as hg diff does not.
Use 'hg export -g' to create a patch that prevserves binary files and
file permissions.
-Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071018/e3d3abbb/attachment.bin>
More information about the Freeipa-devel
mailing list