[Freeipa-devel] [PATCH] quick get_entry refactor

Kevin McCarthy kmccarth at redhat.com
Thu Oct 11 17:31:47 UTC 2007


Simo Sorce wrote:
> On Thu, 2007-10-11 at 10:12 -0700, Kevin McCarthy wrote:
> > Kevin McCarthy wrote:
> > > Kevin McCarthy wrote:
> > > > The current get_entry_by_dn() call doesn't work on non-leaf
> > entries.
> > > > The underlying __get_entry() call always uses scope of SUB.  I'm
> > not
> > > > sure what the best API is for this, but attached is a quick fix,
> > > > separating the calls into get_base_entry() and get_sub_entry().
> > > 
> > > Sorry, I blew it with this patch.  I'll post a fixed one shortly.
> > 
> > Revised patch attached.
> 
> Looks good please push.
> 
> P.S: to be absolutely complete you should provide a function to perform
> one level scoped searches, but if we never use that nevermind :-)

Thanks, Simo, pushed.  (so far, we don't have any scope_one searches, so
I'll leave that one out for now :-) )

-Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071011/c7ade878/attachment.bin>


More information about the Freeipa-devel mailing list