[Freeipa-devel] [PATCH] update_entry

[Kevin McCarthy]

Rob Crittenden wrote:
> Kevin McCarthy wrote:
>> This patch unifies the update_group and update_user methods into
>> update_entry.
>> The modivation for this was from the delegation management code, where I
>> need to update the cn=accounts entry.  Although calling update_group()
>> worked, it looked strange.
>> That said, it may be just as offensive to have an API with add_user,
>> delete_user, but update_entry.  I'm open to suggestions.
>>
> I don't understand how update_group looked strange.

Well, basically because it wasn't a group that I was updating, it was an
ACI container.  So that api calls looked like
  aci = get_aci_entry()
  ...
  update_group(aci)

> We can always have an update_user function that is an alias to 
> update_entry.

Sounds like a reasonable solution to me.  Let me rework the patch,
preserving update_user and update_group alias for update_entry.

-Kevin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071015/377bf38e/attachment.bin>