[Freeipa-devel] [PATCH] autotoolize ipa-client

Rob Crittenden rcritten at redhat.com
Wed Oct 17 16:07:17 UTC 2007


William Jon McCann wrote:
>> particular subdirectory.
>>
>> 2. You have a single spec file that creates a bunch of packages (ala
>> openldap, amanda, openoffice, httpd and other big packages).
> 
> Personally, I don't think this is a good idea.  You have nice separate
> directories, packages, spec files, rpms now.  Why would you muddle
> that up into one blob?  One of the reasons I put this patch together
> was to make each package more distinct.

Yeah, I'm waffling on that. I think I'm too close to it now and can't 
put myself into the place of Joe-developer who wants to try to build it 
himself.

> In my experience meta-packages are usually a mistake.  Xorg is a good example.
> It would make is even more difficult than it is now to:
>  * hack on one component
>  * push updates for (only) one component
>  * build an RPM for one component
>  * etc

Good point.

> I just don't see any compelling reason to package the server and
> client together.

I was proposing only the source would be packaged together. Each 
component would be separate, but it still raises the issue where only 
one piece needs an update you've gotta build them all.

So I think I'm ok leaving them separate for now. We still may want/need 
some top-level Makefile to do something useful. I use make-localdist all 
the time to build the packages for testing.

Now, onto some uglier stuff. I poked further at what changes would be 
required for hardcoded paths and what I found isn't pretty.

We have a slew of references to /usr/ in there, from the installer to 
runtime components. I think at least we should centralize this into one 
or two places (/etc/ipa/ipa.conf or some ipaconfig.py file).

The files affected are, at a minimum:

./ipa-gui/ipa-webgui
./ipa-install/ipa-server-install
./ipa-install/share/kdc.conf.template
./ipa-install/test/Makefile
./ipaserver/dsinstance.py
./xmlrpc-server/funcs.py
./xmlrpc-server/ipa.conf
./xmlrpc-server/ipaxmlrpc.py
./xmlrpc-server/test/README

Most of these are: sys.path.append("/usr/share/ipa/")

The two init files (ipa-webgui and ipa-kpasswd) both refer to /usr/sbin.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071017/210604f4/attachment.bin>


More information about the Freeipa-devel mailing list