[Freeipa-devel] [PATCH] rename for fields parameter

[Kevin McCarthy]

Rob Crittenden wrote:
> Kevin McCarthy wrote:
>> Very early on, when I was struggling to get the form infrastructure
>> working I made a bad naming choice for the parameter containing form
>> fields (not the data - just the field widgets).
>> I called them 'user' and 'group'.  Unfortunately we use that variable
>> name all over the code do refer to the hash/entity containing actual
>> data.  This makes the form unnecessarily confusing.
>> I've let it sit, but should really rename it now to make the code more
>> clear  (this is also at Rob's request).
>> So this largish looking patch is simply renaming one parameter in the
>> user, group, and delegate forms.
>> -Kevin
>
> Looks good and much more understandable now.
>
> Thanks for doing this.

pushed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071025/8f6aa4f5/attachment.bin>