[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] Don't allow default service principals to be removed



David Hollis wrote:
On Fri, 2008-04-25 at 16:58 -0400, Rob Crittenden wrote:
         if entry is None:
             raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND)
+        dn_list = ldap.explode_dn(entry['dn'].lower())
+        if "cn=kerberos" in dn_list:
+            raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND)

I don't know squat about python, but should the exception thrown be
LDAP_NOT_FOUND or should it be INPUT_SERVICE_PRINCIPAL_REQUIRED that was
defined higher up in the patch?



Ack, nice catch. I'll fix it up and resubmit.

rob

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]