[Freeipa-devel] [PATCH] tool to manage search and user policy
Rob Crittenden
rcritten at redhat.com
Fri Aug 15 17:09:44 UTC 2008
Martin Nagy wrote:
> Rob Crittenden wrote:
>> The CLI had no tool to manage the Search and User policy though the
>> web UI did. This patch adds a new tool to edit these values.
>>
>> rob
>
> No comments to the name of the utility :)
> Just a very few minor details:
>
> .dotest/patch:176: trailing whitespace.
> if options.show:
>
> From ipa-admintools/ipa-policyconfig, function update_policy():
> For some attributes, the minimum of 0 is not appropriate.
> For the string attributes, I'd say specifying min=0 isn't required.
>
> Otherwise, the patch seems fine to me.
>
> Martin
I rebased the patch, changed the tool name to ipa-defaultoptions, fixed
the trailing space and the min allowed values.
rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-76-policy.patch
Type: text/x-patch
Size: 57 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080815/85cec4b0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080815/85cec4b0/attachment-0001.bin>
More information about the Freeipa-devel
mailing list