[Freeipa-devel] [PATCH] tool to manage search and user policy

Martin Nagy mnagy at redhat.com
Mon Aug 4 15:01:42 UTC 2008


Rob Crittenden wrote:
> The CLI had no tool to manage the Search and User policy though the web 
> UI did. This patch adds a new tool to edit these values.
> 
> rob

No comments to the name of the utility :)
Just a very few minor details:

.dotest/patch:176: trailing whitespace.
     if options.show:

 From ipa-admintools/ipa-policyconfig, function update_policy():
For some attributes, the minimum of 0 is not appropriate.
For the string attributes, I'd say specifying min=0 isn't required.

Otherwise, the patch seems fine to me.

Martin




More information about the Freeipa-devel mailing list