[Freeipa-devel] [PATCH] Fix slew of errors reported by rpmlint (and do some re-org)

Rob Crittenden rcritten at redhat.com
Thu Jan 17 19:39:48 UTC 2008


This started as an effort to move everything out of /usr/share because I 
thought we weren't FHS compliant. Turns out that we probably are, I 
think my confusion was the shebangs (#!) in many of the scripts.

I still moved most of /usr/share/ipa/ipaserver into 
python/site-packages/ipaserver and I moved ipaclient as well.

Mark had good reasoning for moving the stuff from ipaserver: it is 
shared between the UI and XML-RPC so it makes more sense to be in the 
standard python shared code location.

ipaclient was so self-contained it made sense to move that too.

The result is a much cleaner ipaserver directory in /usr/share/ipa.

The rest of the fixes related to issues in the init scripts such as 
using a variable name with the locks. It confused the heck out of 
rpmlint and it just seemed easier to quiet it down.

I also added the status command to ipa-webgui.init and ipa_kpasswd.ini.

Renamed ipa-kpasswd.init to ipa_kpasswd.init to be consistent with the 
underlying binary.

So now we have no rpmlint errors beyond no documentation in many of the 
RPMs. We can quiet those down by including the GPLv2+ LICENSE and/or 
actually populating the various README's spread throughout the tree. 
Most are empty.

You won't hurt my feelings if you hate what I've done so speak up now.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-595-rpmlint.patch
Type: text/x-patch
Size: 34848 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080117/0f4ac559/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080117/0f4ac559/attachment-0001.bin>


More information about the Freeipa-devel mailing list