[Freeipa-devel] [PATCH] create tmp directory for ipa-kpasswd
Masato Taruishi
taruishi at redhat.com
Thu May 1 17:23:46 UTC 2008
> On Thu, 2008-05-01 at 11:47 -0400, Simo Sorce wrote:
> > On Fri, 2008-05-02 at 00:25 +0900, Masato Taruishi wrote:
> > > This patch creates temporarl directory before mkstemp(2)
> > > in ipa-kpasswd.
> > >
> > > Because mkstemp doesn't create directories, it may fail
> > > with ENOENT.
> >
> > Nack,
> > the kpasswd directory must be created by make install/spec file and
> > properly SELinux labeled (where available).
> >
> > Current F9 package is broken in this respect :-( but we already fixed
> > the spec file.
I didn't see the selinux things and thought directories under
/var/cache should be created on demand for manual deletion.
It seems an old style. Please ignore the patch.
> To be fair, we should probably change the code to retrieve the TMP_DIR
> from the environment so that it can be changed at runtime, I would love
> to get a patch that implements that and sets the correct default
> in /etc/sysconfig/ipa-kpasswd
I think using localstatedir specified in configure is enough to
determine the cache directory. Changing the directory at runtime
makes its initialization complex for selinux.
--
Masato Taruishi <taruishi at redhat.com>
More information about the Freeipa-devel
mailing list