[Freeipa-devel] [PATCH] detect failure to write ipa_kpasswd.pid file

[Jim Meyering]

Simo Sorce <ssorce at redhat.com> wrote:
...
> yes but it depends on what you balance for.
> I tend to balance for debuggability in gdb, which asks for code to be
> split in lines so that you can easily set break points.

Please consider giving more weight to readability and maintainability,
since the code is invariably read more often than debugged.

> Also I tend to use tools like cscope/ctags/etc... and colorized editors
> so that readability even of long variables is not a big problem usually.

I use those same tools, but afaik, none of them can highlight the
duplication or warn me about the lack thereof in the long-named
example I gave.

> Anyway, whom writes the code get to decide, as this specific detail is
> not covered by our coding style guide.

no argument here ;-)

I'll stop harping, now.