[Freeipa-devel] [PATCH] Fix error checking in ipa_kpasswd.c

Simo Sorce ssorce at redhat.com
Fri May 16 13:55:59 UTC 2008


On Fri, 2008-05-16 at 09:28 -0400, Rob Crittenden wrote:
> Simo Sorce wrote:
> > As per $SUBJ
> > 
> 
> partial ack.
> 
> My only nit is an extra comma in two response messages:
> 
> exterr0 = "Password change, Succeeded.";
> exterr0 = "Password change, Failed.";
> 
> I think "Password change [succeeded/failed]" is fine here.
> 
> Fix those and you'll have a full ack :-)

Hey, I just copied the previous messages, this ain't new stuff :-)

Ok, I will fix before pushing :)

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list