[Freeipa-devel] [PATCH] Fix mem leaks in password plugin
Simo Sorce
ssorce at redhat.com
Fri Nov 21 00:56:39 UTC 2008
On Thu, 2008-11-20 at 15:01 -0800, Nathan Kinder wrote:
> Simo Sorce wrote:
> > $subject
> >
> Use slapi_ch_free_string() for freeing char * types instead of
> slapi_ch_free() as in your patch. This lets you avoid an ugly cast to
> void** (which you are missing, and should be getting warning about).
>
> void slapi_ch_free(void **ptr);
> void slapi_ch_free_string(char **s);
>
> Other than the above, it looks good.
Ok changed to slapi_ch_free_string() and pushed to master and ipa-1-2
Simo.
--
Simo Sorce * Red Hat, Inc * New York
More information about the Freeipa-devel
mailing list