[Freeipa-devel] [PATCH] Fix architecture detection in ldapupdate

Martin Nagy mnagy at redhat.com
Fri Sep 19 11:59:09 UTC 2008


On Fri, 19 Sep 2008 07:42:39 -0400, Stephen Gallagher
<sgallagh at redhat.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Martin Nagy wrote:
> > I noticed the architecture detection won't work, since
> > platform.platform() will return something like
> > 'Linux-2.6.25.14-108.fc9.i686-i686-with-fedora-9-Sulphur'. After the
> > patch the detection should be better and we explicitly ask about the
> > bits, not just the arch.
> > 
> > I also did a tiny change in a while loop.
> > 
> > Martin
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> Since I don't know where this return value goes, I want to ask a
> question. Is it only the 64-bit nature that matters, or is the x86_64
> architecture directly relevant?
> 
> In other words, the previous code was checking for x86_64 processors
> only, but now you've expanded it to potentially include IA64,
> Sparc64, etc.

Quickly doing git grep LIBARCH, the code seems to be using this in
"/usr/lib$LIBARCH/dirsrv/plugins/schemacompat-plugin.so", which means
we really need the bits. I think Rob only checked for x86_64 because
FreeIPA doesn't work with other 64 bit architectures (am I right about
this?).

Martin




More information about the Freeipa-devel mailing list