[Freeipa-devel] [PATCH] sssd: style and const fixes for common/

Simo Sorce ssorce at redhat.com
Tue Apr 7 02:20:50 UTC 2009


The recently pushed common/ code does not conform to sssd style
guidelines.

The first patch address the style issue.
Note: I gave authorship to Dmitri as this are just sytle fixes, and I
don't want to snatch authorship of the code (man git-annotate if you
don't know what I am talking about :)

The second patch fixes const warnings, it make strings that the
functions should not touch const.
I strongly recommend this second patch as it is important from a public
API to give guarantees to applications about what it is going to touch
and keeps us honest too, avoid touching string that come from user
applications by mistake.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Style-fixes-for-common.patch
Type: text/x-patch
Size: 256933 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090406/88bf95af/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-const-warnings.patch
Type: text/x-patch
Size: 47792 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090406/88bf95af/attachment-0001.bin>


More information about the Freeipa-devel mailing list