[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] Use proper error for Kerberos and Network in cli



On Fri, 2009-04-03 at 16:19 -0400, Rob Crittenden wrote:
> This enhances the last patch adding an except for GSSAPI errors and also 
> adds one for XML-RPC protocol errors.

nack.  We should catch the ProtocolError at it's source.  Put this at
the bottom of xmlclient.forward() (ipalib/rpc.py).

There are a lot of reasons to wrap exceptions in a PublicError, but one
that I probably haven't documented is that is consolidates code, makes
it simpler to write applications atop ipalib.  If we add these exception
handlers in cli.py, we also have to add the same to any other client
built on ipalib.  This especially doesn't work well with plugability.
We want applications built atop ipalib to only need to know about
PublicError.

So for the record, I'm not just being a pain.  ;)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]