[Freeipa-devel] [PATCH] common fn. to read config strings as lists

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simo Sorce wrote:
> On Tue, 2009-04-14 at 11:29 -0400, Simo Sorce wrote:
>> This also fixes the [service/nss] filters so that you can specify a
>> list
>> of users/groups
> 
> New patch, to resolve merge issue with the patch for Steve that got just
> pushed.
> Also fix a copy&paste error in nss_get_config()
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


Nack, you should be using SERVICE_CONF_ENTRY here:

@@ -557,61 +552,20 @@ int get_monitor_config(struct mt_ctx *ctx)
         return ret;
     }

- -    ret = confdb_get_string(ctx->cdb, ctx,
- -                            SERVICE_CONF_ENTRY, "activeServices",
- -                            NULL, &svcs);
- -
- -    if (ret != EOK || svcs == NULL) {
+    ret = confdb_get_string_as_list(ctx->cdb, ctx, "config/services",
+                                    "activeServices", &ctx->services);
+    if (ret != EOK) {
         DEBUG(0, ("No services configured!\n"));
         return EINVAL;
     }

Fix that one-liner and it's an Ack.

- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknk0iQACgkQeiVVYja6o6OZ7gCgjUPIQLo8l7Nw36Ggtl+4x276
aFsAnR+uRFC0mU75GrYbH3FoCZu75N0s
=b3Rx
-----END PGP SIGNATURE-----