[Freeipa-devel] [PATCH] Finish work replacing errors.py with errors2.py

[Simo Sorce]

On Mon, 2009-04-20 at 12:54 -0600, Jason Gerard DeRose wrote:
> On Mon, 2009-04-20 at 14:02 -0400, Rob Crittenden wrote:
> > Simo Sorce wrote:
> > > On Wed, 2009-04-15 at 10:35 -0400, Rob Crittenden wrote:
> > >> Finish up the work replacing errors.py with errors2.py.
> > >>
> > >> I went ahead and updated both the old and the new ldap modules so we 
> > >> could get this done.
> > >>
> > >> The next step will be to rename errors2 to errors. I didn't do that
> > >> here 
> > >> in order to simplify the review process. That patch will be done once 
> > >> this one is committed (it will be a super-trivial but very long
> > >> patch).
> > > 
> > > looks good
> > > (although I'd split reformatting fixes in a separate patch)
> > > 
> > > Simo.
> > > 
> > 
> > I split the whitespace changes into a separate commit. My editor 
> > automatically did that whitespace removal :-)
> > 
> > pushed to master
> > 
> > rob
> 
> Thanks, Rob.
> 
> We should really all have our editors configured to strip trailing
> whitespace... it helps keep the diffs meaningful and readable.

Or change our git config to always use --withespace=fix :-)

Simo.