[Freeipa-devel] [PATCHES] start/stop related fixes

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Hrozek wrote:
> On Thu, 2009-04-30 at 12:02 -0400, Stephen Gallagher wrote:
>>> Fix initscript return codes is pretty straightforward - just return
>>> correct values in initscript functions. These two patches should
>> address
>>> ticket #28.
>>>
>>> The third one redirects stderr when starting sssd to a temporary
>> logfile
>>> and only prints it when something fails during the startup. This
>> should
>>> address ticket #27.
>> Why are you doing rm -f $LOGFILE at the end of start()? Won't you
>> erase
>> any startup error messages?
>>
> 
> Yes, but after printing them to stderr if needed. The logfile is
> temporary for the startup.
> 
> The intent was to save stderr to a temporary logfile, check if sssd
> started correctly, if so, don't show the stderr output (as it contains
> the "Unable to register control with rootdse!" messages), if it failed
> to start, print the error messages.
> 

Ok, I think I misread it.
In that case, it's fine.

>>> The last one removes the pid file on quitting sssd, right now the
>> pid
>>> file is left in /var/run after sssd finished which doesn't seem
>> right.
>>> Related to this - should sssd be a single-instance daemon? If so,
>>> there's another bug in pidfile() - a second instance of sssd that's
>> ran
>>> overwrites the pid file. 
>>>
>> Yes, SSSD MUST be single-instance. Please fix that and roll it into
>> this
>> patch.
>>
> 
> OK. I also noticed that it's trying to remove the pid file for all
> processes, which is wrong, should be done only for sssd, I need to fix
> that, too.
> 


- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkn529QACgkQeiVVYja6o6N4wQCfXhuvd1/aBQh5nAMNAJDwH6dV
Ly0AnRmHA/LKxqCuR1E6FEDPkot5NxWc
=jRvw
-----END PGP SIGNATURE-----