[Freeipa-devel] [PATCH] 324 add errors.NotImplementedError

Rob Crittenden rcritten at redhat.com
Tue Dec 1 22:23:27 UTC 2009


This deprecates a similar patch from John last month. The server-side 
baseclass rabase defines a framework for CA plugins. When I added this 
code I set it up to return errors.NotImplementedError but didn't 
actually include that error class in the commit.

I'm adding that in now, favoring it over the python built-in exception 
of the same name because it is more friendly to the client (they get a 
"command not implemented" instead of an InternalError.

Ideally we should not register commands that aren't implemented, I'll 
tackle that soon but for now this will fill in the gap.

This also wraps the call to cert_revoke() in the service plugin to not 
blow up if using the selfsign CA which doesn't implement revocation.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-324-errors.patch
Type: application/mbox
Size: 2595 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091201/dfdfaa21/attachment.mbox>


More information about the Freeipa-devel mailing list