[Freeipa-devel] [PATCH] 324 add errors.NotImplementedError

Jason Gerard DeRose jderose at redhat.com
Wed Dec 2 06:28:04 UTC 2009


On Tue, 2009-12-01 at 17:23 -0500, Rob Crittenden wrote:
> This deprecates a similar patch from John last month. The server-side 
> baseclass rabase defines a framework for CA plugins. When I added this 
> code I set it up to return errors.NotImplementedError but didn't 
> actually include that error class in the commit.
> 
> I'm adding that in now, favoring it over the python built-in exception 
> of the same name because it is more friendly to the client (they get a 
> "command not implemented" instead of an InternalError.
> 
> Ideally we should not register commands that aren't implemented, I'll 
> tackle that soon but for now this will fill in the gap.
> 
> This also wraps the call to cert_revoke() in the service plugin to not 
> blow up if using the selfsign CA which doesn't implement revocation.
> 
> rob

ack.  pushed to master.




More information about the Freeipa-devel mailing list