[Freeipa-devel] [PATCH] First part of the ELAPI interface (resend)

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/14/2009 09:48 AM, Dmitri Pal wrote:
> Sumit Bose wrote:
>> On Mon, Jul 13, 2009 at 07:42:26PM -0400, Dmitri Pal wrote:
>>   
>>> Dmitri Pal wrote:
>>>     
>>>> This is just a part of the interface,
>>>> a beginning. Most likely some of the functions
>>>> will be altered but it is a starting point.
>>>> For example in future there will be
>>>> a way to override some of the parts of the
>>>> default template using the application configuration file.
>>>>
>>>>
>>>> I just need to start somewhere. More to come during the week.
>>>>
>>>>   
>>>>       
>>> Forgot the attachment...
>>>
>>>     
>> Just a few general comments for a start.
>> - I think you have to add the m4 subdirectory to the repository, too.
>>   autoreconf does not create it automatically
>>   
> I noticed that too but thought it is a problem with my configuration.
> Steven is that the case?

Yes, the m4 directory needs to be present. The way I've done this in the
past is to add a m4/.dir zero-length file to the repository. I don't
know how to make git add an empty directory otherwise.

> 
>> - please change configure.ac and Makefile.am according to Stephen's
>>   recent patch to include all thew usual -W* flags to AM_CFLAGS
>>   
> I can do it in a separate patch on top of this one.
> No need to jam things together. But I will take a look.

Since you're going back and modifying this patch anyway, please include
this.

> 
>> - I get a "'COL_ADD_MODE_FLAT' undeclared"
>>   
> It is declared in one of the two previous patches I submitted.
> They have not been pushed yet. You need all three for things to work.
> On relies on another.
> 
> Thanks for taking a look.
> 
>> bye,
>> Sumit
>>   
> 
> 


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpcngoACgkQeiVVYja6o6NPxQCfT1K/m87oFiUcMnK/wxeKomJi
YjYAn2RoBilBFEN3+6GXROfLFECWQSYE
=b1t3
-----END PGP SIGNATURE-----