[Freeipa-devel] [PATCH] Notify user when deleting nonexistent user or group

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/30/2009 01:36 PM, Jakub Hrozek wrote:
> On 07/30/2009 06:50 PM, Jakub Hrozek wrote:
>> Before a deletion, search the sysdb for the entity and error
>> out if it cannot be found.
> 
>> Fixes: RHBZ #513247, RHBZ #513250
> 
>> 	Jakub
> 
> This patch did conflict with the return codes patch. Attached are
> rebased versions that can be applied on top of one another.
> 
> 	Jakub


The return codes patch remains acked.

I'm going to nack the user notification patch. I think we need to think
some more about this. The sysdb has an interface in place for returning
ENOENT when trying to delete, we're just setting it
state->ignore_not_found = true; in sysdb_delete_entry_send().

I think the correct thing to do would be to modify that function so that
it accepted a boolean value for whether or not to ignore it if it's not
found.

This way, we aren't doing an extra search.
- ------------------------------------------------------------------------

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpx6jcACgkQeiVVYja6o6MsZQCglbRO/wJp5IT2OswjadNCGP5V
ojIAn2ZmfYlWjnIpmgNwGpp5KvDk8TkT
=uGcx
-----END PGP SIGNATURE-----