[Freeipa-devel] [PATCH][SSSD] Fix invalid pointer in ldb_debug_message

Simo Sorce ssorce at redhat.com
Thu Jun 4 18:12:28 UTC 2009


On Thu, 2009-06-04 at 13:39 -0400, Stephen Gallagher wrote:
> -    DEBUG(loglevel, (fmt, ap));
> +    vasprintf(&message, fmt, ap);''

NACK, you don't chek vasprintf return value or if message != NULL

> +    va_end(ap);

NACK, the caller does this.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list