[Freeipa-devel] Re: [PATCHES] Add support for incomplete (truncated) search results.

[Pavel Zůna]

Rob Crittenden wrote:
> Pavel Zůna wrote:
>> Rob Crittenden wrote:
>>> Pavel Zuna wrote:
>>>> Patch 0001: Add support for incomplete (truncated) search results.
>>>>
>>>> ldap2 didn't have the capability to return search results when a DS 
>>>> limitation got exceeded (an exception was raised).
>>>>
>>>> Pavel
>>>
>>> I think truncated should be initialized to False, not None. It looks 
>>> like this could actually be transported across XML-RPC and I don't 
>>> believe we've enabled the NULL option (and I'd rather avoid doing so).
>>>
>>> If this is ok I can make this change before committing the patch.
>>>
>>> rob
>>
>> It is set to None, because otherwise it gets encoded into a string by 
>> the decode_retval decorator. If that's a problem I'll rework 
>> decode_retval.
>>
>> Pavel
> 
> Well, in general it would be nice if we could return booleans as welll, 
> that is a supported XML-RPC data type.
> 
> rob
> 

The decode_retval decorator currently decodes everything returned by the 
decorated function into the python unicode type except None (unless 
configured otherwise). There is no option to only decode a certain part, 
but it shouldn't be hard to rework it to be similar to encode_args. I 
didn't think of this, because it is only used by find_entries at this point.

Pavel