[Freeipa-devel] [PATCHES][SSSD] Fix two segfaults related to config file reloading

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/19/2009 11:50 AM, Simo Sorce wrote:
> On Fri, 2009-06-19 at 11:35 -0400, Stephen Gallagher wrote:
>> 0001: This segfault was caused by only talloc_steal()ing the first
>> entry
>> in a linked list. The other entries were freed, causing a segfault the
>> next time they were accessed. I've added a memory context for the
>> whole
>> linked list that can be passed to the new config in order to bring
>> along
>> all of the entries in the list.
> 
> ack, but remove the redundant domain->next = NULL before pushing
> 
>> 0002: There is a race condition (that is fairly involved and will be
>> dealt with separately) where signal_service_reload will attempt to
>> signal a child process that does not yet have an active sbus channel.
>> In
>> that case, we'll just skip signaling it (since it won't get its
>> initial
>> configuration until it's up anyway).
> 
> ack, but the debug statements say "deferring" while the function is
> actually skipping, please remove the "Deferring." part before pushing.
> 
> Simo.
> 

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAko7ta8ACgkQeiVVYja6o6NhCQCgjf3oVi85B6hIdolIXJ7xTtj1
s0YAn1s3VN8EUOaUKqwv6Ctrl47bd638
=BtnI
-----END PGP SIGNATURE-----