[Freeipa-devel] [PATCH][SSSD] Implement GetUserAttributes in the InfoPipe

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simo Sorce wrote:
> On Mon, 2009-03-02 at 13:58 -0500, Simo Sorce wrote:
>> On Mon, 2009-03-02 at 11:49 -0500, Simo Sorce wrote:
>>> I prefer to make it very clear that the owner of the map must own the
>>> contents as well.
>>> The map is useful only for its owner after all, I don't see a case where
>>> it would be useful for a map to survive its owner.
>> Patch attached, I did not convert keys to be char *, but I removed any
>> stealing, we must just make sure the memory for keys or values is either
>> static or allocated on the same mem context that holds the btreemap.
> 
> Small update to remove dead code and some const warnings.
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Ack

Looks fine to me. Just need to make sure we don't drop the memory that
the btreemap is looking at.

- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmsQXIACgkQeiVVYja6o6ND+gCffGyvRZ6v4BcoeYMGUjQtcIoj
aKYAni8ulwsKWXv73hzR93nI4eNjAhxl
=dF4p
-----END PGP SIGNATURE-----