[Freeipa-devel] [PATCH][SSSD] Fixing memory leak in GetUserAttributes
Simo Sorce
ssorce at redhat.com
Wed Mar 4 14:01:06 UTC 2009
On Wed, 2009-03-04 at 06:54 -0500, Stephen Gallagher wrote:
> Martin Nagy wrote:
> > Stephen Gallagher wrote:
> >> Trivial fix. I forgot to unref the reply message after sending it
> (or
> >> if construction of the message failed).
> >
> > Hm, this seems to be a bit dangerous.. I think a better idea would
> be
> > to initialize reply to NULL and then do a test after the done label:
> >
> > if (reply)
> > dbus_message_unref(reply);
> >
> > Martin
>
> New patch attached incorporating Martin's suggestion.
ack and pushed
--
Simo Sorce * Red Hat, Inc * New York
More information about the Freeipa-devel
mailing list