[Freeipa-devel] [PATCH][SSSD] Clean up warnings in monitor.c

Stephen Gallagher sgallagh at redhat.com
Tue May 12 12:33:18 UTC 2009


On 05/12/2009 02:38 AM, Sumit Bose wrote:
> Stephen Gallagher schrieb:
>> Updated patch, also cleaning up warning in confdb.c
>>
>> On 05/11/2009 02:43 PM, Stephen Gallagher wrote:
>>> GCC 4.4.0 reveals more warnings than previous versions.
>>>
>>> Clean up function prototype, return without value and pointer signedness
>>> warnings.
>>>
> 
> All changes make sense to me. Wouldn't it be nicer to have
> "opt_config_file = talloc_strdup(NULL, CONFDB_DEFAULT_CONFIG_FILE);"
> after server_setup? Then you can use main_ctx and do not have to create
> a top level context for opt_config_file.
> 
> bye,
> Sumit

I'd rather not have it be a child of the server_setup, actually.
Valgrind can't tell if it's lost at that point. However, I have modified
the code so that it's explicitly talloc_free()-ed immediately after
monitor configuration. I checked to make sure that it was
talloc_strdup()-ed into the confdb_file_ctx inside, so it's safe to
remove it.

Please see the new patch.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-warnings-in-monitor.c-and-confdb.c.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090512/98231c66/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090512/98231c66/attachment.p7s>


More information about the Freeipa-devel mailing list