[Freeipa-devel] [PATCH] Check for valid ID ranges and ID overlaps between domains
Stephen Gallagher
sgallagh at redhat.com
Thu May 14 13:00:33 UTC 2009
On 05/14/2009 08:50 AM, Jakub Hrozek wrote:
> On Mon, 2009-05-11 at 13:23 -0400, Stephen Gallagher wrote:
>> Nack. If a domain has an invalid range specified, it should be an
>> error,
>> not a warning. (e.g. id_min >= id_max, id_min or id_max < 0, etc.)
>>
>> Also, I'd prefer if you used a variable name other than "first" for
>> the
>> outer loop. It gives the impression that you're always comparing
>> against
>> the first domain in the list.
>>
>
> Another iteration attached. Returns EINVAL on invalid range, only prints
> DEBUG(1,...) on overlap.
>
> Jakub
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
Ack
--
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090514/eb10cd93/attachment.p7s>
More information about the Freeipa-devel
mailing list