[Freeipa-devel] [PATCH] gettext cleanups

Stephen Gallagher sgallagh at redhat.com
Fri May 29 11:25:38 UTC 2009


On 05/29/2009 02:51 AM, Sumit Bose wrote:
> Simo Sorce schrieb:
>> On Thu, 2009-05-28 at 15:43 -0400, Simo Sorce wrote:
>>> On Thu, 2009-05-28 at 07:49 -0400, Stephen Gallagher wrote:
>>>> Ack, and thanks for sorting this out.
>>> pushed
>> btw I merged once again changes to .po and .pot files as the line number
>> in master was different from what was specified in the patch ...
>>
>> I guess this means that whoever changes pam_sss.c will have th duty to
>> run make dist and make sure that .po and .pot changes are part of the
>> patch as well...
>>
>> Simo.
>>
> The line numbers in the .po files can be supressed with --no-location
> which can be added to XGETTEXT_OPTIONS in Makevars. But I do not know if
> it is a good or bad idea to use this.
> 
> bye,
> Sumit
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

My suggestion would be to move the actual strings into a -i18n header
(e.g. pam-i18n.h) and just use #defines in the actual code. Then we only
need to worry about updating the translations if the translation string
headers are modified.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090529/2dba959e/attachment.p7s>


More information about the Freeipa-devel mailing list