[Freeipa-devel] [PATCH] move LOCAL auth into a separate backend

Simo Sorce ssorce at redhat.com
Fri May 29 13:11:17 UTC 2009


On Fri, 2009-05-29 at 09:09 -0400, Stephen Gallagher wrote:
> On 05/29/2009 09:06 AM, Sumit Bose wrote:
> > Stephen Gallagher schrieb:
> >> I'd like to see the individual back-ends stored in their own directories
> >> (keeping the trend set by the LDAP back-end). Can you move the
> >> LOCAL_auth backend into a "LOCAL" subdirectory?
> >>
> >> Similarly, (though probably in a separate patch) I'd like to see the
> >> proxy moved down a level as well.
> >>
> >> Basically I want it to be easy and less cluttered if we decide to add
> >> back-end-specific helper files, so everything can be kept in one place.
> >>
> >> On to the review:
> >> It's only in the comments, but the header for LOCAL_auth.c reads:
> >> "PAM e credentials"
> >> I'm not sure what you meant to write there. Maybe "Native LOCAL Backend"
> >> would be accurate.
> >>
> >> Other than that, I'd say it looks pretty good to me.
> >>
> > valid points, new version attached
> > 
> > bye,
> > Sumit
> 
> Ack

NACK,
see my other email.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list