[Freeipa-devel] [PATCH] 309 make exception from ipautil.run() optional

[Rob Crittenden]

Rob Crittenden wrote:
> There are probably occasions where a caller will want more control over 
> what happens when running a command fails. I've added an optional 
> argument to run where it will not raise an exception on errors.
> 
> I've also added returncode to the tuple of things returned.
> 
> rob

I forgot to include this additional change in the patch. When acked I'll 
add this bit too and commit it.

--- a/ipaserver/install/httpinstance.py
+++ b/ipaserver/install/httpinstance.py
@@ -100,7 +100,7 @@ class HTTPInstance(service.Service):
          if selinux:
              try:
                  # returns e.g. "httpd_can_network_connect --> off"
-                (stdout, stderr) = ipautil.run(["/usr/sbin/getsebool",
+                (stdout, stderr, returncode) = 
ipautil.run(["/usr/sbin/getsebool",
 
"httpd_can_network_connect"])
                  self.backup_state("httpd_can_network_connect", 
stdout.split()[2])
              except:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091111/41ba5e33/attachment.bin>