[Freeipa-devel] [PATCH] Fix incorrect imports in ipa-server-certinstall. [Was: consistent use of --help on CLI?]

[Pavel Zuna]

Fixed.

Pavel Zuna wrote:
> Dmitri Pal wrote:
>> Pavel, Rob,
>>
>> What do the CLI utils do when someone uses "--help" parameter?
>> Is there a consistent behavior about this?
>>
>> Thanks
>> Dmitri
> Yes there is, we use OptionParser from python optparse module everywhere 
> as far as I know and it handles -h/--help by default.
> 
>>
>>
>> David O'Brien wrote:
>>> Is this achievable or desirable? Instead of the results below, display
>>> the man page (like ipa-server-install --help does) or at least not
>>> crap out...
>>>
>>> [root at cairo ~]# ipa-server-certinstall --help
>>> Traceback (most recent call last):
>>>  File "/usr/sbin/ipa-server-certinstall", line 31, in ?
>>>    from ipaserver import certs, dsinstance, httpinstance, ipaldap,
>>> installutils
>>> ImportError: cannot import name certs
>>>
>>> cheers
> The problem here, is that python cannot import the certs modules from 
> ipaserver/install. It has nothing to do with options (--help). If you 
> run it without it - same results. The rule of thumb in these situations 
> is to actually read the error message, it might give a hint about where 
> the problem is. ;-)
> 
> Anyway, I'll try to fix it.
> 
>>>
>>> [root at cairo ~]# rpm -qi ipa-server
>>> Name        : ipa-server                   Relocations: (not 
>>> relocatable)
>>> Version     : 2.0                               Vendor: Red Hat, Inc.
>>> Release     : 3.20090908.el5ipa             Build Date: Tue 08 Sep
>>> 2009 06:04:31 PM EST
>>> Install Date: Wed 09 Sep 2009 10:32:56 AM EST      Build Host:
>>> x86-005.build.bos.redhat.com
>>> Group       : System Environment/Base       Source RPM:
>>> ipa-2.0-3.20090908.el5ipa.src.rpm
>>> Size        : 2768258                          License: GPLv2
>>>
>>
>>
> 
> Pavel
> 

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-incorrect-imports-in-ipa-server-certinstall.patch
Type: application/mbox
Size: 979 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090910/738624d4/attachment.mbox>