[Freeipa-devel] [PATCH] 396 with verbose print XML-RPC output

Martin Nagy mnagy at redhat.com
Tue Apr 20 05:57:01 UTC 2010


On Mon, 2010-04-19 at 16:37 -0400, Rob Crittenden wrote:
> Rob Crittenden wrote:
> > Martin Nagy wrote:
> >> On 03/05/2010 07:45 PM, Rob Crittenden wrote:
> >>> Connect the -v flag in the ipa command to including the XML-RPC
> >>> conversation in the output:
> >>>
> >>> % ipa -v user-show admin
> >> [snip]
> >>
> >> Rob, do you think we could use something like -vv for this? The 
> >> XML-RPC conversation seems to be a little bit too verbose.
> >>
> >> Martin
> > 
> > Hmm, maybe. verbose is currently a boolean. We could switch the option 
> > to be a 'count' and return the number of v's. So 0 is still False, 1 is 
> > still True and anything higher we can compare against a number. I think 
> > that would work, I'll take a look.
> > 
> >
> 
> I switched the boolean -v to a counter.
> 
> A single -v enables more verbose logging
> Two -v's enables printing the XML-RPC request
> 
> rob

The patch looks good, but I think you should also modify the default in
constants.py

Martin




More information about the Freeipa-devel mailing list